Liron Aravot has posted comments on this change. Change subject: core: add disk profile to disk's commands ......................................................................
Patch Set 3: (1 comment) partially reviewed, please move the code that repeats itself to a helper to to a method that'll be used by all the commands. marking -1 for visibility. http://gerrit.ovirt.org/#/c/29038/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java: Line 23: private StorageDomain storageDomain; Line 24: private List<DiskProfile> diskProfiles; Line 25: Line 26: public DiskProfileValidator(DiskProfile diskProfile) { Line 27: this(diskProfile.getId()); NPE in case that diskProfile is null Line 28: this.diskProfile = diskProfile; Line 29: } Line 30: Line 31: public DiskProfileValidator(Guid diskProfileId) { -- To view, visit http://gerrit.ovirt.org/29038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b6d977243cffc0bde772665ebaca47340075c6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
