Mike Kolesnik has posted comments on this change. Change subject: engine: Consider mac pool in data-center actions ......................................................................
Patch Set 6: Code-Review-1 (4 comments) Doesn't seem to be any real changes here, especially not what is described in the commit message. I think it's safe to drop this patch http://gerrit.ovirt.org/#/c/28981/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java: Doesn't seem like this file need to be touched at all in this patch Line 1: package org.ovirt.engine.core.bll.storage; Line 2: Line 3: import java.util.Collections; Line 4: import java.util.List; http://gerrit.ovirt.org/#/c/28981/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 84: return; Line 85: } Line 86: } Line 87: Line 88: final Guid storagePoolId = getStoragePoolId(); Unused variable, please don't add it Line 89: Line 90: removeDataCenter(); Line 91: Line 92: getMacPoolForDataCenter().freeMacs(macsToRemove); http://gerrit.ovirt.org/#/c/28981/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 61: Line 62: @Override Line 63: protected void executeCommand() { Line 64: updateQuotaCache(); Line 65: final StoragePool storagePool = getStoragePool(); No need to extract to variable Line 66: if (_oldStoragePool.getStatus() == StoragePoolStatus.Up) { Line 67: if (!StringUtils.equals(_oldStoragePool.getName(), storagePool.getName())) { Line 68: runVdsCommand(VDSCommandType.SetStoragePoolDescription, Line 69: new SetStoragePoolDescriptionVDSCommandParameters( Line 73: } Line 74: Line 75: copyUnchangedStoragePoolProperties(storagePool, _oldStoragePool); Line 76: Line 77: Guid requestedMacPoolId = storagePool.getMacPoolId(); Not sure what the purpose of this code is but it reminds me of https://www.youtube.com/watch?v=Z86V_ICUCD4 i.e. it's not doing anything of value Line 78: if (requestedMacPoolId != null) { Line 79: getStoragePool().setMacPoolId(requestedMacPoolId); Line 80: } Line 81: -- To view, visit http://gerrit.ovirt.org/28981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f988cf803bea7cbd9670b42e48f665706166795 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
