Lior Vernia has posted comments on this change. Change subject: webadmin: AddRemoveRowWidget to enable/disable rows ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/29228/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java: Line 181: public void onValueChange(ValueChangeEvent<T> event) { Line 182: T value = event.getValue(); Line 183: boolean becomingGhost = isGhost(value); Line 184: if (becomingGhost != wasGhost) { Line 185: setButtonsEnabled(widget, !becomingGhost); > what about the enabled? Fixed by putting this logic in toggleGhost(). Line 186: toggleGhost(value, widget, becomingGhost); Line 187: wasGhost = becomingGhost; Line 188: } Line 189: } http://gerrit.ovirt.org/#/c/29228/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java: Line 78 Line 79 Line 80 Line 81 Line 82 > Why was the 'enabled' removed from here? This subclass doesn't need to be aware of enabled/disabled matters. Everything is taken care of by the superclass. Line 79 Line 80 Line 81 Line 82 Line 83 > same Same. Line 80 Line 81 Line 82 Line 83 Line 84 > I saw this code was moved to AddRemoveRowWidget.addEntry(), but as I wrote There probably was a bug there, now it should be okay. -- To view, visit http://gerrit.ovirt.org/29228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a6265b5c0eb27c3b99b98d88986762249acdbe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
