Juan Hernandez has posted comments on this change. Change subject: sdk: Regenerate against the latest api ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29452/1/src/ovirtsdk/infrastructure/brokers.py File src/ovirtsdk/infrastructure/brokers.py: Line 13142: FilterHelper.filter(result, kwargs), Line 13143: context=self.context Line 13144: ) Line 13145: Line 13146: class SchedulingPolicieBalance(params.Balance, Base): This name is wrong, it should be SchedulingPolicy, please regenerate again after applying these patches: http://gerrit.ovirt.org/29418 http://gerrit.ovirt.org/29419 If with those patches the name is correct, then we will need to merge them before merging this one. Line 13147: def __init__(self, schedulingpolicie, balance, context): Line 13148: Base.__init__(self, context) Line 13149: self.parentclass = schedulingpolicie Line 13150: self.superclass = balance http://gerrit.ovirt.org/#/c/29452/1/src/ovirtsdk/xml/params.py File src/ovirtsdk/xml/params.py: Line 30199 Line 30200 Line 30201 Line 30202 Line 30203 This shouln't be changed. Make sure you modify it manually, after the regeneration, it needs to be "VersionCaps". This is a bug of the Python SDK that we should fix some day. Line 384: # Line 385: # Globals Line 386: # Line 387: Line 388: ExternalEncoding = 'ascii' The encoding shouldn't change, change it back to UTF-8 after re-generating. Line 389: Tag_pattern_ = re_.compile(r'({.*})?(.*)') Line 390: String_cleanup_pat_ = re_.compile(r"[\n\r\s]+") Line 391: Namespace_extract_pat_ = re_.compile(r'{(.*)}(.*)') Line 392: -- To view, visit http://gerrit.ovirt.org/29452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a07e5fa704f5a739ea94f6826d9c471bbf3b0ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
