Liron Aravot has posted comments on this change. Change subject: core: add disk profile to newly created storage domain ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29037/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 73: // create default disk profile for type master or data storage domains Line 74: if (storageStaticData.getStorageDomainType().isDataDomain()) { Line 75: getDiskProfileDao().save(DiskProfileHelper.createDiskProfile(storageStaticData.getId(), Line 76: storageStaticData.getStorageName())); Line 77: } see questions in previous patchset. Line 78: getCompensationContext().snapshotNewEntity(storageStaticData); Line 79: StorageDomainDynamic newStorageDynamic = Line 80: new StorageDomainDynamic(null, getStorageDomain().getId(), null); Line 81: getReturnValue().setActionReturnValue(getStorageDomain().getId()); -- To view, visit http://gerrit.ovirt.org/29037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
