Liron Aravot has posted comments on this change. Change subject: core: always attempt to clear tasks without vdsm id ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28951/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 331: } else { Line 332: getReturnValue().setCanDoAction(false); Line 333: } Line 334: } finally { Line 335: freeLockExecute(); > Liron, Ravi has a point here. Yair, As i see it - when command execution end, there shouldn't be any task placeholders as it's the command decision to be made wether it's succesful or not. I don't see how that affects async execution of command because i'm unware of the implementation details of it, but it shouldn't affect it as i see it. Currently we have already two flows affected flow by this issue. Line 336: clearAsyncTasksWithOutVdsmId(); Line 337: } Line 338: return getReturnValue(); Line 339: } -- To view, visit http://gerrit.ovirt.org/28951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib98e90eb3e078761b9ad9d0a30b21c9db20bd7d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
