Martin Peřina has posted comments on this change. Change subject: webadmin: Rename "kdump detection" to "kdump integration" ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/29478/1/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 831: ISCSI_BOND_REMOVE_SUCCESS=iSCSI bond '${IscsiBondName}' was removed from Data Center '${StoragePoolName}' Line 832: ISCSI_BOND_REMOVE_FAILED=Failed to remove iSCSI bond '${IscsiBondName}' from Data Center '${StoragePoolName}' Line 833: Line 834: FENCE_KDUMP_LISTENER_IS_NOT_ALIVE=Unable to determine if Kdump is in progress on host '${VdsName}', because fence_kdump listener is not running. Line 835: KDUMP_FLOW_DETECTED_ON_VDS=Kdump flow in progress on host '${VdsName}'. > is in progress? Neither am I, but term "on host" is used in this file and I didn't found any usage of "at host" term. Line 836: KDUMP_FLOW_NOT_DETECTED_ON_VDS=Kdump flow not in progress on host '${VdsName}'. Line 837: KDUMP_FLOW_FINISHED_ON_VDS=Kdump flow finished on host '${VdsName}'. Line 832: ISCSI_BOND_REMOVE_FAILED=Failed to remove iSCSI bond '${IscsiBondName}' from Data Center '${StoragePoolName}' Line 833: Line 834: FENCE_KDUMP_LISTENER_IS_NOT_ALIVE=Unable to determine if Kdump is in progress on host '${VdsName}', because fence_kdump listener is not running. Line 835: KDUMP_FLOW_DETECTED_ON_VDS=Kdump flow in progress on host '${VdsName}'. Line 836: KDUMP_FLOW_NOT_DETECTED_ON_VDS=Kdump flow not in progress on host '${VdsName}'. > is not in progress? Done Line 837: KDUMP_FLOW_FINISHED_ON_VDS=Kdump flow finished on host '${VdsName}'. Line 834: FENCE_KDUMP_LISTENER_IS_NOT_ALIVE=Unable to determine if Kdump is in progress on host '${VdsName}', because fence_kdump listener is not running. Line 835: KDUMP_FLOW_DETECTED_ON_VDS=Kdump flow in progress on host '${VdsName}'. Line 836: KDUMP_FLOW_NOT_DETECTED_ON_VDS=Kdump flow not in progress on host '${VdsName}'. Line 837: KDUMP_FLOW_FINISHED_ON_VDS=Kdump flow finished on host '${VdsName}'. Line 838: KDUMP_DETECTION_NOT_CONFIGURED_ON_VDS=Kdump integration is enabled for host '${VdsName}', but kdump is not configured properly on host. > because kdump is not...? In this case I disagree. Here "Kdump integration" is enabled in PM options of host (checkbox), but for some it's not properly configured on the host (for example kdump service is not running). http://gerrit.ovirt.org/#/c/29478/1/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1043: ACTION_TYPE_FAILED_RNG_SOURCE_NOT_SUPPORTED=Cannot ${action} ${type}. Random Number Generator device is not supported in cluster. Line 1044: ACTION_TYPE_RNG_MUST_BE_SPECIFIED=Cannot ${action} ${type}. Random Number Generator must be specified in parameters. Line 1045: Line 1046: KDUMP_DETECTION_NOT_ENABLED_FOR_VDS=Cannot ${action} ${type}. Kdump integration is not enabled for host '${VdsName}'. Line 1047: KDUMP_DETECTION_NOT_CONFIGURED_ON_VDS=Cannot ${action} ${type}. Kdump integration is not properly configured on host '${VdsName}'. > kdump is not properly Again, kdump can be configured properly even without fence_kdump options, but here we want to display error, that 1) Kdump is not configured at all 2) Or it's configured without fence_kdump options 3) Or Kdump service is not running http://gerrit.ovirt.org/#/c/29478/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 1502: Line 1503: @DefaultStringValue("Boot Time") Line 1504: String bootTimeHostGeneral(); Line 1505: Line 1506: @DefaultStringValue("Kdump Integration") > Kdump status is ok if I guess where it is used. This is label that shows status of kdump integration configuration. Even if kdump is configured properly, but without fence_kdump options, "Disabled" is displayed to user. Line 1507: String kdumpStatus(); Line 1508: Line 1509: @DefaultStringValue("SELinux mode") Line 1510: String selinuxModeGeneral(); -- To view, visit http://gerrit.ovirt.org/29478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bdcf78eb27902951f0298b13bf671bebd828fc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
