Mike Kolesnik has posted comments on this change. Change subject: engine: Introduce mac pool for data center queries ......................................................................
Patch Set 6: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28983/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMacPoolByIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMacPoolByIdQuery.java: Line 11: } Line 12: Line 13: @Override Line 14: protected void executeQueryCommand() { Line 15: final Guid id = getParameters().getId(); This can be inlined Line 16: final MacPool macPool = getDbFacade().getMacPoolDao().get(id); Line 17: Line 18: getQueryReturnValue().setReturnValue(macPool); Line 19: } http://gerrit.ovirt.org/#/c/28983/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 244: GetAllStorageServerConnections, Line 245: GetStorageServerConnectionsForDomain, Line 246: GetStoragePoolById(VdcQueryAuthType.User), Line 247: GetMacPoolById(VdcQueryAuthType.User), Line 248: GetMacPoolsByDataCenterId(VdcQueryAuthType.User), Both should not be authorized for user as this is not targeted to users just admins. Line 249: GetStoragePoolByDatacenterName(VdcQueryAuthType.User), Line 250: GetStorageDomainsByConnection, Line 251: GetConnectionsByDataCenterAndStorageType, Line 252: GetStorageDomainsByStoragePoolId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/28983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bebcc750d2b349993947800ccf01a1df43c3e72 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
