Nir Soffer has posted comments on this change. Change subject: jsonrpc: Missing hostId parameter on reconstructMaster ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29511/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 571: int leaseRetries, Line 572: int hostSpmId) { Line 573: // no lockPolicy and hostSpmId not needed can be removed from the interface Line 574: JsonRpcRequest request = Line 575: new RequestBuilder("StoragePool.reconstructMaster").withParameter("storagepoolID", spUUID) The storagePoolID parameters should not be here, unless it is not sent to vdsm. In the vdsm log we can see that the first parameter sent was poolName. Line 576: .withParameter("hostId", hostSpmId) Line 577: .withParameter("name", poolName) Line 578: .withParameter("masterSdUUID", masterDom) Line 579: .withParameter("masterVersion", masterVersion) -- To view, visit http://gerrit.ovirt.org/29511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe40b9f054278a7ffe108efb0e2c5a60bf643b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
