Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Allow separate hosts for dwh/reports ......................................................................
Patch Set 37: Verified+1 Verified on fedora 20 that yum update from master nightly snapshot to a build with this change in keeps the file /etc/ovirt-engine-setup.conf.d/10-packaging-jboss.conf unchanged. Verified both by upgrading with yum (without running engine-setup before that) and with engine-setup (after running setup on the master snapshot). Also, if after installing from master snapshot, I edited the file, then upgraded to this change, the file's contents were left untouched and included my editing, and yum did not warn/complain nor created any backup (.rpmnew/.rpmsave). Not sure that's the exact intended behavior, but it at least caused no damage. Note that the change introducing ovirt_provides_jboss was merged to 3.4, then reverted due to problems before releasing any version with it. I understand it's intended to be available in 3.4.3. I do not fully understand the discussion in [1] so not sure what other tests are needed. But I do not think this is very relevant to this change - in 3.4.3 we'll simply have to use the common package as well. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1055604 -- To view, visit http://gerrit.ovirt.org/27502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
