Yair Zaslavsky has posted comments on this change.

Change subject: bll: don't add user if login fails
......................................................................


Patch Set 2:

Why are you suggesting this change?
As Alon suggested,  we have to add the user in order to perform the permissions 
check.
Not sure why do u think there is a difference between a case that a user has 
groups or not?

-- 
To view, visit http://gerrit.ovirt.org/29525
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7434c45a3aca7ed74002f65ab3315e86233e1530
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondřej Macháček <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ondřej Macháček <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to