Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: No red warning when export template that already exists. ......................................................................
webadmin: No red warning when export template that already exists. Template -> select one -> Export If this template has already been exported, the popup shuld contain a red message which warns that this has already been exported. The problem was in TemplateListModel.showWarningOnExistingTemplates method which used synchronous queries to retrive storage_pool and templates on the export domain which does not work on the GWT envirotnment. Fixed by extracting and generalizing the correct logic from VmListModel to a common parent VmBaseListModel and calling this common logic. Added also a progress animation, until all the required data are fetched from server, so will not happen, that the window will not contain the warning message for a while and will look like there is no warning. Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 3 files changed, 309 insertions(+), 347 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
