Martin Peřina has posted comments on this change. Change subject: dal: Refactor VmStatic and VmTemplate Daos ......................................................................
Patch Set 1: (6 comments) http://gerrit.ovirt.org/#/c/29544/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java: Line 55: @Override Line 56: public VmTemplate get(Guid id, Guid userID, boolean isFiltered) { Line 57: return getCallsHandler().executeRead("GetVmTemplateByVmtGuid", Line 58: VMTemplateRowMapper.instance, Line 59: createIdParameterMapper(id).addValue("user_id", userID).addValue("is_filtered", isFiltered)); Please format using standard Java Coding Conventions Line 60: } Line 61: Line 62: @Override Line 63: public VmTemplate getByName(String name, Guid userID, boolean isFiltered) { Line 63: public VmTemplate getByName(String name, Guid userID, boolean isFiltered) { Line 64: return getCallsHandler().executeRead("GetVmTemplateByVmtName", Line 65: VMTemplateRowMapper.instance, Line 66: getCustomMapSqlParameterSource() Line 67: .addValue("vmt_name", name).addValue("user_id", userID).addValue("is_filtered", isFiltered)); Please format using standard Java Coding Conventions Line 68: } Line 69: Line 70: @Override Line 71: public List<VmTemplate> getAll() { Line 78: VMTemplateRowMapper.instance, Line 79: getCustomMapSqlParameterSource() Line 80: .addValue("entity_type", entityType.name()) Line 81: .addValue("user_id", userID) Line 82: .addValue("is_filtered", isFiltered)); Please format using standard Java Coding Conventions Line 83: } Line 84: Line 85: @Override Line 86: public List<VmTemplate> getVmTemplatesByIds(List<Guid> templatesIds) { Line 85: @Override Line 86: public List<VmTemplate> getVmTemplatesByIds(List<Guid> templatesIds) { Line 87: return getCallsHandler().executeReadList("GetVmTemplatesByIds", Line 88: VMTemplateRowMapper.instance, Line 89: getCustomMapSqlParameterSource().addValue("vm_templates_ids", StringUtils.join(templatesIds, ','))); Please format using standard Java Coding Conventions Line 90: } Line 91: Line 92: @Override Line 93: public List<VmTemplate> getAllForStorageDomain(Guid storageDomain) { Line 100: VMTemplateRowMapper.instance, Line 101: getCustomMapSqlParameterSource() Line 102: .addValue("storage_domain_id", storageDomain) Line 103: .addValue("user_id", userID) Line 104: .addValue("is_filtered", isFiltered)); Please format using standard Java Coding Conventions Line 105: } Line 106: Line 107: @Override Line 108: public List<VmTemplate> getAllWithQuery(String query) { Line 154: @Override Line 155: public List<VmTemplate> getAllTemplatesWithDisksOnOtherStorageDomain(Guid storageDomainGuid) { Line 156: return getCallsHandler().executeReadList("GetAllVmTemplatesWithDisksOnOtherStorageDomain", Line 157: VMTemplateRowMapper.instance, Line 158: getCustomMapSqlParameterSource().addValue("storage_domain_id", storageDomainGuid)); Please format using standard Java Coding Conventions Line 159: } Line 160: Line 161: @Override Line 162: protected MapSqlParameterSource createFullParametersMapper(VmTemplate template) { -- To view, visit http://gerrit.ovirt.org/29544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c02c11ededf4dfba67e5cc8598ae90155d7eb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
