Martin Betak has posted comments on this change. Change subject: dal: Remove duplicate fields in VM row mappers ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29518/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java: Line 152: * @param columnName the name of the column. Line 153: * @return a {@link Guid} representing the UUID in the column, or the default value if it was <code>null</code>. Line 154: * @throws SQLException If resultSet does not contain columnName or its value cannot be cast to {@link UUID}. Line 155: */ Line 156: public static Guid getGuid(ResultSet resultSet, String columnName) throws SQLException { > Why are you make here public and in next patch you revert this back to prot Yes this was done only for the purpose of splitting the patch into two. In the first the getGuid method is required in the AbstractVmRowMapper but the row mapper is not yet moved to the same package as the declaring class. In the second patch we move it to the newly created VmBaseDaoDbFacade where it is available and we may restrict the visibility back to the original. Line 157: return getGuid(resultSet, columnName, null); Line 158: } Line 159: Line 160: /** -- To view, visit http://gerrit.ovirt.org/29518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab2a3bf9a0deb25b3950f75a351bde4b9e6fef74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
