Liron Aravot has uploaded a new change for review. Change subject: core: always attempt to clear tasks without vdsm id ......................................................................
core: always attempt to clear tasks without vdsm id Even when command execution succeeds, for some reason it may leave task placeholders that were added for some reason (For example - in case that the commands ignores a specific failure in creating a task). The execution method should always delete those entries at the end of the execution. Change-Id: Ib98e90eb3e078761b9ad9d0a30b21c9db20bd7d5 Bug-Url: https://bugzilla.redhat.com/1103687 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/29552/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 7f07c59..0631fa6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -346,9 +346,7 @@ } } finally { freeLockExecute(); - if (!getReturnValue().getSucceeded()) { - clearAsyncTasksWithOutVdsmId(); - } + clearAsyncTasksWithOutVdsmId(); } return getReturnValue(); } -- To view, visit http://gerrit.ovirt.org/29552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib98e90eb3e078761b9ad9d0a30b21c9db20bd7d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
