Yaniv Dary has posted comments on this change. Change subject: packaging: setup: allow reports on separate host ......................................................................
Patch Set 38: (6 comments) http://gerrit.ovirt.org/#/c/28479/38/Makefile File Makefile: Line 45: ovirt-engine please change to ENGINE NAME parameter. http://gerrit.ovirt.org/#/c/28479/38/ovirt-engine-reports.spec.in File ovirt-engine-reports.spec.in: Line 33: engine_user please remove duplicates http://gerrit.ovirt.org/#/c/28479/38/packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py File packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py: Line 1: #!/usr/bin/python Please open bug on this to refactor the service code to one core. Line 2: Line 3: # Copyright 2014 Red Hat Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); http://gerrit.ovirt.org/#/c/28479/38/packaging/setup/ovirt_engine_setup/reports/constants.py File packaging/setup/ovirt_engine_setup/reports/constants.py: Line 49: PKI_REPORTS_JBOSS_CERT_NAME sync with engine http://gerrit.ovirt.org/#/c/28479/38/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py: Line 81: ), Line 82: ) Line 83: def _closeup(self): Line 84: # TODO add some condition to not do this if engine+reports are on Line 85: # same host Please do this for the user and write to restart on remote. and this needs to happen before engine restart. Line 86: self.dialog.note( Line 87: text=_( Line 88: 'To update the Reports link on the main web interface page, ' Line 89: 'please update the database and restart the engine service, ' http://gerrit.ovirt.org/#/c/28479/38/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 978: addition = libxml2.parseDoc( Line 979: ''' Line 980: <folder>%s</folder> Line 981: ''' % Line 982: self.environment[oreportscons.JasperEnv.THEME] Please check this with latest pep8. should work. Line 983: ) Line 984: xml.xpath.xpathEval('/folder')[0].addChild( Line 985: addition.getRootElement() Line 986: ) -- To view, visit http://gerrit.ovirt.org/28479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426f040446e6288f481f9a256ddbfa35ce729e0b Gerrit-PatchSet: 38 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
