Moti Asayag has uploaded a new change for review. Change subject: engine: Use ValidationResult enhancements in ProviderValidator ......................................................................
engine: Use ValidationResult enhancements in ProviderValidator The ValidationResult.failWith().when() provides a nice api for validation. The patch uses it in ProviderValidator. Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/29608/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java index 0f18bbb..0d53049 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java @@ -19,13 +19,12 @@ } public ValidationResult nameAvailable() { - return getProviderDao().getByName(provider.getName()) == null - ? ValidationResult.VALID - : new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED); + return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED) + .when(getProviderDao().getByName(provider.getName()) != null); } public ValidationResult providerIsSet() { - return provider == null ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST) - : ValidationResult.VALID; + return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST) + .when(provider == null); } } -- To view, visit http://gerrit.ovirt.org/29608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibcff64a7f77a95a6ae788c8871c7d673829a0223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
