Lior Vernia has posted comments on this change.

Change subject: webadmin: LabelWithTooltip trims long text and add "..."
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Please fix small typo (see inline).

http://gerrit.ovirt.org/#/c/29125/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextOverflow.java:

Line 10: import com.google.gwt.user.client.ui.Composite;
Line 11: import com.google.gwt.user.client.ui.Label;
Line 12: 
Line 13: /*
Line 14:  * In case the lable's text is cropped, the text is visually trimmed. 
To let the user know that the text was trimmed
label.
Line 15:  * '...' (three dots) are appended to the string. The tooltip contains 
the full text
Line 16:  * string.
Line 17:  */
Line 18: public class LabelWithTextOverflow extends Composite implements 
IsEditor<LeafValueEditor<String>> {


-- 
To view, visit http://gerrit.ovirt.org/29125
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0c6292b874d0994042366940123b42b38b7a8d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to