Mike Kolesnik has posted comments on this change.
Change subject: Engine: Ovf reader will fail if image StorageId doesnt exists
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 94: if
(!StringHelper.isNullOrEmpty(storageNode.InnerText)) {
I think this should stay selection of StoragePoolId, otherwise you will set the
storage id as the storage pool id.
--
To view, visit http://gerrit.ovirt.org/5344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7652cc4a0d750b72a83178a54cb042d4bd40b163
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
