Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: fixing a dependency problem ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29456/2/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/dialog/titles.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/dialog/titles.py: Line 43: super(Plugin, self).__init__(context=context) Line 44: Line 45: @plugin.event( Line 46: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 47: name=oengcommcons.Stages.DB_OWNERS_CONNECTIONS_CUSTOMIZED, > Why add a new file and not add to packaging/setup/plugins/ovirt-engine-setu Cause it was under ovirt-engine-common/base/ and I want to minimize the change, if it's really used only in the setup I can move to ovirt-engine-setup/ovirt-engine-common. I'll check. Line 48: before=( Line 49: oengcommcons.Stages.DIALOG_TITLES_E_DATABASE, Line 50: ), Line 51: after=( -- To view, visit http://gerrit.ovirt.org/29456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1dd12d87951e322a2863a5723db4cef23a12c2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
