Mike Kolesnik has posted comments on this change. Change subject: Engine: Set correct storage id for snapshots ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java Line 159: image.setstorage_ids(null); Please look at synchronizeDisksFromSnapshot method, when disk marked as illegal then there is a reference to the storage id's array first element which I suspect will fail on NPE. -- To view, visit http://gerrit.ovirt.org/5322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I579838d688e11fbef3beb96ddb876447fe36ab65 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
