Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Disconnecting from vdsm for maintanace ......................................................................
Patch Set 2: Code-Review-1 isn't there another way to accomplish that? sounds weird that we need to call addVds and removeVds, rather than to issue a connect/disconnect in this use case. Also, having a code there that tests whether the protocol is STOMP is probably a wrong idea. Please try to find a better solution for this one. -- To view, visit http://gerrit.ovirt.org/29651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ed4a9c88204dff120914384497e1d6034645fae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
