Ravi Nori has posted comments on this change. Change subject: engine : Save CommandContext in ContextCache ......................................................................
Patch Set 5: (2 comments) replied http://gerrit.ovirt.org/#/c/29501/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java http://gerrit.ovirt.org/#/c/29501/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 75: } Line 76: } Line 77: } Line 78: Line 79: void persistCommandContext(Guid cmdId, CommandContext cmdContext) { > why package visibility and not private? this method is called from CommandExecutor, so left it as package Line 80: if (cmdContext != null) { Line 81: contextsCache.put(cmdId, cmdContext); Line 82: } Line 83: } Line 81: contextsCache.put(cmdId, cmdContext); Line 82: } Line 83: } Line 84: Line 85: CommandContext getCommandContext(Guid cmdId) { > same? this could be private, but wanted to keep it consistent with the method above. Do you prefer private here? Line 86: return contextsCache.get(cmdId); Line 87: } Line 88: Line 89: /** -- To view, visit http://gerrit.ovirt.org/29501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b968f787b60f83cf96411a97dd6380421f724b9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
