Simone Tiraboschi has posted comments on this change. Change subject: sdk: Ignore errors when cleaning old connection ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29684/2/src/codegen/templates/entrypointtemplate File src/codegen/templates/entrypointtemplate: Line 38: # ref-count == 0 Line 39: if context.manager.has_key(self.__id): Line 40: try: Line 41: self.disconnect() Line 42: except Exception: Maybe is enough to catch DisconnectedError but I don't know if disconnect() can raise different exceptions. Catching everything can hide other problems. Line 43: pass Line 44: Line 45: # Remove trailing slashes from the URL: Line 46: url = url.rstrip('/') -- To view, visit http://gerrit.ovirt.org/29684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2a5c690aa9336bc0b441ca57100b9d6cd09e335 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
