Liron Aravot has posted comments on this change. Change subject: core: add GetDiskProfilesByStorageQosIdQuery ......................................................................
Patch Set 2: Code-Review-1 (1 comment) minor issue, marking -1 for visibillity. what about dao test? http://gerrit.ovirt.org/#/c/29529/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/ProfilesDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/ProfilesDao.java: Line 15: * @param qosId Line 16: * the QoS's ID Line 17: * @return the list of profiles Line 18: */ Line 19: List<DiskProfile> getAllForQos(Guid qosId); - the return type here should be T Line 20: } -- To view, visit http://gerrit.ovirt.org/29529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8e675506cf698d6545a69c919220835fcb835c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
