Alona Kaplan has posted comments on this change. Change subject: webadmin: Network dialog- default/custom mtu as radio buttons ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28099/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 721: Line 722: private void setMtuSelectorsChangeability(boolean isChangeable, String prohibitionReason) { Line 723: if (!isChangeable) { Line 724: getMtuSelector().setChangeProhibitionReason(prohibitionReason); Line 725: getMtu().setChangeProhibitionReason(prohibitionReason); > Similar to comment below, this should also happen if (!isChangeable || !isC The prohibition reason here is the reason that the whole mtu + selector widget is not changeable (for example have provider or under 3.0). So it should be shown just in case !changeable. isCustomMtu() is not related to it. Line 726: } Line 727: Line 728: getMtuSelector().setIsChangable(isChangeable); Line 729: getMtu().setIsChangable(isChangeable); -- To view, visit http://gerrit.ovirt.org/28099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f813fd292b56407c97ae69c1580061bbc0eef04 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
