Juan Hernandez has posted comments on this change.
Change subject: cli: No regular expression for IP, UUID or number
......................................................................
Patch Set 1:
Currently, before this patch, the IPADDR and UUID terminal types are used in
places where the WORD terminal type is also accepted. For example:
def p_argument(self, p):
"""argument : IPADDR
| UUID
| WORD
| STRING
| NUMBER
"""
p[0] = p[1]
There is no conversion of the token text to any type, it stays as string, as it
was initially. We don't use the type of the tokens (t.type) anywhere, they are
only used internally by the lexer and the parser.
The only case where we do a special treatment of the token text is for NUMBER,
as we convert the token text to integer. Other than that NUMBER always appears
in productions where WORD is also accepted.
So this patch doesn't break anything.
--
To view, visit http://gerrit.ovirt.org/29722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ilia Meerovich <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
