Piotr Kliczewski has posted comments on this change. Change subject: core: VdsManager - no need to cache config values ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27375/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 136: Line 137: public void schedulJobs() { Line 138: SchedulerUtil sched = SchedulerUtilQuartzImpl.getInstance(); Line 139: int refreshRate = Config.<Integer> getValue(ConfigValues.VdsRefreshRate) * 1000; Line 140: Please remove white space. Line 141: // start with refresh statistics Line 142: _refreshIteration = _numberRefreshesBeforeSave - 1; Line 143: Line 144: onTimerJobId = -- To view, visit http://gerrit.ovirt.org/27375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
