Piotr Kliczewski has posted comments on this change. Change subject: core: monitoring - Create a VM manager to co-ordinate monitoring and commands ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28173/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java: Line 13: import org.ovirt.engine.core.utils.transaction.TransactionSupport; Line 14: Line 15: import java.util.concurrent.locks.ReentrantLock; Line 16: Line 17: public class VmManager { What about implementing AutoCloseable and use try with resources? Line 18: Line 19: private final Guid id; Line 20: private final ReentrantLock lock = new ReentrantLock(); Line 21: -- To view, visit http://gerrit.ovirt.org/28173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
