Hello Idan Shaby,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29810
to review the following change.
Change subject: core: ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS
......................................................................
core: ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS
ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS' error message claims that
only a storage domain's name can be updated, but according to the code,
the name, description and comment can be updated.
This patch fixes this message accordingly.
Change-Id: Idf9049d0e47bcf3c96ccd73f70907dce2c47460b
Signed-off-by: Allon Mureinik <[email protected]>
Signed-off-by: Idan Shaby <[email protected]>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/29810/1
diff --git
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
index 33de79b1..9ee1420 100644
---
a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
+++
b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
@@ -545,7 +545,7 @@
ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action}
${type}. Storage format ${storageFormat} is not supported on the selected host
version.
ERROR_CANNOT_EXTEND_NON_DATA_DOMAIN=Cannot extend Storage Domain. Extend
operation is supported only on Data Storage Domain.
ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain. Storage
device ${lun} is unreachable on ${hostName}.
-ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name is updateable.
+ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name, description and comment are updateable.
ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS=Cannot
update Data Center compatibility version to a value that is greater than its
Cluster's version. The following clusters should be upgraded ${ClustersList}.
ERROR_CANNOT_ADD_EXISTING_STORAGE_DOMAIN_CONNECTION_DATA_ILLEGAL=Cannot import
Storage Domain. Internal Error: The connection data is illegal.
ERROR_CANNOT_ADD_DEPRECATED_EXISTING_SAN_EXPORT_STORAGE_DOMAIN=Cannot import
SAN Export Storage Domain as it is no longer supported.
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
index ca4fd21..74e94d1 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
@@ -1510,7 +1510,7 @@
@DefaultStringValue("Cannot extend Storage Domain. Storage device ${lun}
is unreachable from ${hostName}.")
String ERROR_CANNOT_EXTEND_CONNECTION_FAILED();
- @DefaultStringValue("Cannot ${action} ${type}. Only Storage Domain name is
updateable.")
+ @DefaultStringValue("Cannot ${action} ${type}. Only Storage Domain name,
description and comment are updateable.")
String ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS();
@DefaultStringValue("Cannot update Data Center compatibility version to a
value that is greater than its Cluster's version. The following clusters should
be upgraded ${ClustersList}.")
diff --git
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index c238683..a8f1622 100644
---
a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++
b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -517,7 +517,7 @@
ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action}
${type}. Storage format ${storageFormat} is not supported on the selected host
version.
ERROR_CANNOT_EXTEND_NON_DATA_DOMAIN=Cannot extend Storage Domain. Extend
operation is supported only on Data Storage Domain.
ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain. Storage
device ${lun} is unreachable from ${hostName}.
-ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name is updateable.
+ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name, description and comment are updateable.
ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS=Cannot
update Data Center compatibility version to a value that is greater than its
Cluster's version. The following clusters should be upgraded ${ClustersList}.
ERROR_CANNOT_ADD_EXISTING_STORAGE_DOMAIN_CONNECTION_DATA_ILLEGAL=Cannot import
Storage Domain. Internal Error: The connection data is illegal.
ERROR_CANNOT_ADD_DEPRECATED_EXISTING_SAN_EXPORT_STORAGE_DOMAIN=Cannot import
SAN Export Storage Domain as it is no longer supported.
diff --git
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
index 8f95528..0ad832f 100644
---
a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
+++
b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
@@ -550,7 +550,7 @@
ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action}
${type}. Storage format ${storageFormat} is not supported on the selected host
version.
ERROR_CANNOT_EXTEND_NON_DATA_DOMAIN=Cannot extend Storage Domain. Extend
operation is supported only on Data Storage Domain.
ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain. Storage
device ${lun} is unreachable from ${hostName}.
-ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name is updateable.
+ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}. Only
Storage Domain name, description and comment are updateable.
ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS=Cannot
update Data Center compatibility version to a value that is greater than its
Cluster's version. The following clusters should be upgraded ${ClustersList}.
ERROR_CANNOT_ADD_EXISTING_STORAGE_DOMAIN_CONNECTION_DATA_ILLEGAL=Cannot import
Storage Domain. Internal Error: The connection data is illegal.
ERROR_CANNOT_ADD_DEPRECATED_EXISTING_SAN_EXPORT_STORAGE_DOMAIN=Cannot import
SAN Export Storage Domain as it is no longer supported.
--
To view, visit http://gerrit.ovirt.org/29810
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf9049d0e47bcf3c96ccd73f70907dce2c47460b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
