Hello Idan Shaby,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29806
to review the following change.
Change subject: core: StorageDomainManagementCommandBase's DAOs
......................................................................
core: StorageDomainManagementCommandBase's DAOs
Replaced call to DbFacade.getInstance().getStorageDomainStaticDao() with
getStorageDomainStaticDAO() as per the backend's convention.
This change is done in order to facilitate writing unit tests.
Change-Id: Ief680d1131104d28d9ec2850257bd84ff28fe5ad
Signed-off-by: Allon Mureinik <[email protected]>
Signed-off-by: Idan Shaby <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/29806/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
index 8bef8b1..968428e 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
@@ -3,7 +3,6 @@
import org.ovirt.engine.core.common.action.StorageDomainManagementParameter;
import org.ovirt.engine.core.common.businessentities.StorageDomain;
import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
public abstract class StorageDomainManagementCommandBase<T extends
StorageDomainManagementParameter> extends
StorageDomainCommandBase<T> {
@@ -31,6 +30,6 @@
}
protected boolean isStorageWithSameNameExists() {
- return
DbFacade.getInstance().getStorageDomainStaticDao().getByName(getStorageDomain().getStorageName())
!= null;
+ return
getStorageDomainStaticDAO().getByName(getStorageDomain().getStorageName()) !=
null;
}
}
--
To view, visit http://gerrit.ovirt.org/29806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief680d1131104d28d9ec2850257bd84ff28fe5ad
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
