Lior Vernia has posted comments on this change. Change subject: webadmin: Implement sorting for RxTxRateColumn ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28757/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java: Line 8: public class RxTxRateRenderer extends AbstractRenderer<Double[]> { Line 9: Line 10: public static final String NO_VALUE = "[N/A]"; //$NON-NLS-1$ Line 11: public static final String ZERO_VALUE = "0"; //$NON-NLS-1$ Line 12: public static final String SMALL_VALUE = "< 1"; //$NON-NLS-1$ > That is more or less my take on things. If it is going to be shown to a use Gilad, an inability to see into the future doesn't justify not thinking about things. Alex, that is exactly what I'm worried about. Let's take Arabic for example, which has its own digit characters (though the Western digits still exist in their ANSI set, and are default i.e. have the same character values). If a translator translates these strings they might choose the Arabic digits, while the normal values in the column will be shown as Western digits. Line 13: Line 14: @Override Line 15: public String render(Double[] values) { Line 16: if (values.length != 2 || values[0] == null || values[1] == null) { -- To view, visit http://gerrit.ovirt.org/28757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a9b91350e774639a7879e26456f6e8cc15ba3d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
