Maor Lipchuk has posted comments on this change. Change subject: core: wrong messages in AddExistingFileStorageDomain ......................................................................
Patch Set 2: Code-Review+2 (1 comment) see minor comments http://gerrit.ovirt.org/#/c/29782/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 55: } Line 56: Line 57: protected boolean checkExistingStorageDomain() { Line 58: if (DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId()) != null) { Line 59: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST); please use formatter (remove space) Line 60: } Line 61: Line 62: List<Guid> storageIds = (ArrayList<Guid>) runVdsCommand(VDSCommandType.HSMGetStorageDomainsList, Line 63: new HSMGetStorageDomainsListVDSCommandParameters(getVdsId(), Guid.Empty, getStorageDomain() -- To view, visit http://gerrit.ovirt.org/29782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idebeacf0b9332b54cfbdc62d16da89d8ce3478da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
