Tomas Jelinek has posted comments on this change. Change subject: frontend: Change static AsyncDataProvider to singleton ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/29845/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 168: import org.ovirt.engine.ui.uicompat.SpiceConstantsManager; Line 169: Line 170: public class AsyncDataProvider { Line 171: Line 172: private static AsyncDataProvider instance = new AsyncDataProvider(); please init this class lazily in the getInstance() otherwise this instance will be created also for tests. Line 173: Line 174: public static AsyncDataProvider getInstance() { Line 175: return instance; Line 176: } http://gerrit.ovirt.org/#/c/29845/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java: Line 481: public int maxNumOfSockets = 0; Line 482: Line 483: public void updataMaxVmsInPool() { Line 484: AsyncDataProvider.getInstance().getInstance().getMaxVmsInPool(new AsyncQuery(this, Line 485: new INewAsyncCallback() { getInstance().getInstance() ? Line 486: @Override Line 487: public void onSuccess(Object target, Object returnValue) { Line 488: VmModelBehaviorBase behavior = (VmModelBehaviorBase) target; Line 489: behavior.setMaxVmsInPool((Integer) returnValue); Line 549: tempVar.setEntity(diskImage.getSizeInGigabytes()); Line 550: diskModel.setSize(tempVar); Line 551: ListModel tempVar2 = new ListModel(); Line 552: tempVar2.setItems((diskImage.getVolumeType() == VolumeType.Preallocated ? new ArrayList<VolumeType>(Arrays.asList(new VolumeType[] {VolumeType.Preallocated})) Line 553: : AsyncDataProvider.getInstance().getInstance().getVolumeTypeList())); same Line 554: tempVar2.setSelectedItem(diskImage.getVolumeType()); Line 555: diskModel.setVolumeType(tempVar2); Line 556: diskModel.getVolumeType().setIsAvailable(false); Line 557: } -- To view, visit http://gerrit.ovirt.org/29845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bfc604834856e8240703bb8bf64e9a40c3b8c0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
