Maor Lipchuk has posted comments on this change. Change subject: core: add tests for AddExistingBlockStorageDomainCommand ......................................................................
Patch Set 2: Code-Review+2 (1 comment) see minor comments http://gerrit.ovirt.org/#/c/29781/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java: Line 40: when(command.getLUNsFromVgInfo(parameters.getStorageDomain().getStorage())).thenReturn(getLUNs()); Line 41: Line 42: command.executeCommand(); Line 43: Line 44: assertTrue(command.getReturnValue().getSucceeded()); no reason for all of those empty spaces Line 45: } Line 46: Line 47: private StorageDomainStatic getStorageDomain() { Line 48: StorageDomainStatic storageDomain = new StorageDomainStatic(); -- To view, visit http://gerrit.ovirt.org/29781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddcb20d1dcacbbb72c37ffb89449f5451bcccbb8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
