Alexander Wels has posted comments on this change. Change subject: webadmin: cluster sorting ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28361/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java: Line 9: public ClusterConditionFieldAutoCompleter() { Line 10: // Building the basic vervs Dict Line 11: mVerbs.add(NAME); Line 12: mVerbs.add(DESCRIPTION); Line 13: mVerbs.add("COMMENT"); > why not moving all to constants ? Not sure, I only did the columns that were sortable, but I can do the rest as well to be consistent. Line 14: mVerbs.add("ARCHITECTURE"); Line 15: Line 16: // Building the autoCompletion Dict Line 17: buildCompletions(); http://gerrit.ovirt.org/#/c/28361/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java: Line 244: new ClusterConditionFieldAutoCompleter(), Line 245: "vds_groups_view", Line 246: "vds_groups_storage_domain", Line 247: "vds_group_id", Line 248: "name ASC")); > does this really matter ? yes it matters a LOT actually, as the formatter chokes on the fact that there is an extra space and it completely destroys the sorting. Line 249: put(SearchObjects.QUOTA_OBJ_NAME, new EntitySearchInfo(new QuotaConditionFieldAutoCompleter(), Line 250: new QuotaConditionFieldAutoCompleter(), Line 251: "quota_view", Line 252: "quota_view", http://gerrit.ovirt.org/#/c/28361/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/comparators/AffinityGroupComparator.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/comparators/AffinityGroupComparator.java: Line 47: return ((Boolean)group1.isEnforcing()).compareTo(group2.isEnforcing()); Line 48: } Line 49: }; Line 50: Line 51: //TODO sort on members, which is a list of strings, comma separated? > Will this TODO be part of the patch? I dropped this entire file from the patch. -- To view, visit http://gerrit.ovirt.org/28361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7b2d9938a7e9b7e32238a284c0ddca6568b3bdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
