Roy Golan has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27920/5/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java: Line 28: /** Line 29: TODO - ADD TESTS HERE - Line 30: Host and Vms Monitoring now split to 2 classes - all VMs related tests have been move to {@link org.ovirt.engine.core.vdsbroker.VmsMonitoringTest} Line 31: */ Line 32: @Ignore > Why do we want to ignore this test case now? all the tests here are no longer relevant to this class. all Vm related stuff must be in VmAnalyzerTest and VmsMonitoringTest I added test for host monitoring in the recent patch of the set and will add more Line 33: @RunWith(MockitoJUnitRunner.class) Line 34: public class HostMonitoringTest { Line 35: Line 36: @ClassRule -- To view, visit http://gerrit.ovirt.org/27920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
