Martin Peřina has posted comments on this change. Change subject: node: Determine ovirt-node-plugin-vdsm version ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29503/4/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 114: MANAGEMENT_BRIDGE_NAME = 'VDSM/managementBridgeName' Line 115: CHECK_VIRT_HARDWARE = 'VDSM/checkVirtHardware' Line 116: OVIRT_NODE = 'VDSM/node' Line 117: OVIRT_NODE_HAS_OWN_BRIDGES = 'VDSM/nodeHasOwnBridges' Line 118: NODE_PLUGIN_VERSION = 'VDSM/nodePluginVersion' > it is vdsm plugin, not generic one... there may be others I thought as it's ovirt-node-plugin-vdsm, that NODE_PLUGIN_VERSION in VdsmEnv describes it fine, but I can create NodeEnv and move it there. Also there's OVIRT_NODE and OVIRT_NODE_HAS_OWN_BRIDGES in VdsmEnv, so do you want them in VdsmEnv or in NodeEnv? Line 119: CONFIG_OVERRIDE = 'VDSM/configOverride' Line 120: DISABLE_NETWORKMANAGER = 'VDSM/disableNetworkManager' Line 121: CONFIG_PREFIX = 'VDSM_CONFIG/' Line 122: -- To view, visit http://gerrit.ovirt.org/29503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa4fb729cb2db3fba9076a1184d2906cee06868 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
