Moti Asayag has posted comments on this change.

Change subject: engine: allow updating/deleting a network with unplugged vnics 
only
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30020/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/VnicNetworkCanBeUpdatedPredicate.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/VnicNetworkCanBeUpdatedPredicate.java:

Line 2: 
Line 3: import 
org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
Line 4: import org.ovirt.engine.core.utils.linq.Predicate;
Line 5: 
Line 6: public final class VnicNetworkCanBeUpdatedPredicate implements 
Predicate<VmNetworkInterface> {
perhaps VmNetworkCanBeUpdatedPredicate which describes better the nature of the 
network being examined ?
Line 7: 
Line 8:     private static final Predicate<VmNetworkInterface> instance = new 
VnicNetworkCanBeUpdatedPredicate();
Line 9: 
Line 10:     public static Predicate<VmNetworkInterface> getInstance() {


-- 
To view, visit http://gerrit.ovirt.org/30020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib57fd905811bbbb60ef06bae15d0c42518132596
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to