Alon Bar-Lev has posted comments on this change. Change subject: aaa: change code of AddUser and AddGroup ......................................................................
Patch Set 3: (1 comment) looks great! more functionality less code, just the way I like. http://gerrit.ovirt.org/#/c/30039/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 10: import org.ovirt.engine.api.extensions.ExtMap; Line 11: import org.ovirt.engine.core.aaa.AuthzUtils; Line 12: import org.ovirt.engine.core.aaa.DirectoryUtils; Line 13: import org.ovirt.engine.core.common.businessentities.DbUser; Line 14: import org.ovirt.engine.core.compat.Guid; I do not like to see compat leak into here... maybe you can have a function that iterate users and set id if missing? or have this at constructor? Line 15: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 16: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 17: import org.ovirt.engine.core.utils.collections.MultiValueMapUtils; Line 18: import org.ovirt.engine.core.utils.extensionsmgr.EngineExtensionsManager; -- To view, visit http://gerrit.ovirt.org/30039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
