anmolbabu has posted comments on this change.

Change subject: engine: gluster volume geo replication entities
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/29605/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java:

Line 5:     NOTSTARTED,
Line 6:     ACTIVE,
Line 7:     PASSIVE,
Line 8:     STOPPED,
Line 9:     FAULTY;
> Please add a PARTIAL_FAULTY too
Done.


http://gerrit.ovirt.org/#/c/29605/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java:

Line 15:     String slaveNodeHostName;
Line 16:     GeoRepSessionStatus status;
Line 17:     String checkPointStatus;
Line 18:     GeoRepCrawlStatus crawlStatus;
Line 19:     Long files_syncd;
> Change naming to filesSynced..applicable to below too
Done
Line 20:     Long files_pending;
Line 21:     Long bytes_pending;
Line 22:     Long deletes_pending;
Line 23:     Long files_skipped;


-- 
To view, visit http://gerrit.ovirt.org/29605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to