Juan Hernandez has posted comments on this change. Change subject: packaging, tools: Generate engine-config.xml from template ......................................................................
Patch Set 6: > I saw that you implemented data source. Any reason why to continue and use > data source here? Either than that, the code looks good to me, from Java side > point of view. The only reason was to use something similar to what was used before: a factory for connections. The DataSource interface is the usual way to do that. But it is true that a simple connection will be enough for engine-manage-domains and engine-config, not probably for the notification service. What would be your suggestion Yair? -- To view, visit http://gerrit.ovirt.org/5362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c8ff572307a31e5f9f9749e6c3cc41858a2765 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
