Simone Tiraboschi has posted comments on this change. Change subject: packaging: Don't show fence_kdump listener in summary ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29896/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py: Line 49: ) Line 50: def _late_setup_service_state(self): Line 51: self._needStart = self.services.status( Line 52: name=oenginecons.Const.FENCE_KDUMP_LISTENER_SERVICE_NAME, Line 53: ) > Well, what about upgrade 3.5 -> 3.6? If we would like to change default con No, not really. _closeup() checking self._enabled is enough to restart the service also on upgrade. This one is to preserve the status of the service prior to any other action but if it's so tightly coupled to the engine I think we don't need this. Line 54: Line 55: @plugin.event( Line 56: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 57: before=( -- To view, visit http://gerrit.ovirt.org/29896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
