Simone Tiraboschi has uploaded a new change for review.

Change subject: command: making default log file location generic in help text
......................................................................

command: making default log file location generic in help text

The default name of log file contains an execution timestamp;
the command help text prints it evaluating it at command
execution time so that file will not really exist.
Making it generic using a placeholder.

Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633
Bug-Url: https://bugzilla.redhat.com/1061636
Signed-off-by: Simone Tiraboschi <[email protected]>
---
M src/__main__.py
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector 
refs/changes/16/30116/1

diff --git a/src/__main__.py b/src/__main__.py
index 5a9cfec..923f038 100755
--- a/src/__main__.py
+++ b/src/__main__.py
@@ -1433,7 +1433,13 @@
     parser.add_option(
         "", "--log-file",
         dest="log_file",
-        help="path to log file (default=%s)" % DEFAULT_LOG_FILE,
+        help="path to log file (default=%s)" %
+            os.path.join(
+                config.DEFAULT_LOG_DIR,
+                '{prefix}-<TIMESTAMP>.log'.format(
+                    prefix=config.LOG_PREFIX,
+                )
+            ),
         metavar="PATH",
         default=DEFAULT_LOG_FILE
     )


-- 
To view, visit http://gerrit.ovirt.org/30116
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1755c4aa60340be5fb95b7bfba789b4dd33b2633
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to