Tal Nisan has posted comments on this change. Change subject: core: Adding some ctors tests. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29391/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java: Line 19: // Config is used during static initializaion of commands Line 20: // Without the config rules, it will be impossible to retrieve Line 21: // the classes of these commands without an exception Line 22: @ClassRule Line 23: public static MockConfigRule mcr = new MockConfigRule( This can be removed now, I've removed the static initialization in the command in http://gerrit.ovirt.org/29778/ Line 24: mockConfig(ConfigValues.GlusterPeerStatusRetries, 2)); Line 25: Line 26: @Test Line 27: public void testInternalAnnotationCtors() { -- To view, visit http://gerrit.ovirt.org/29391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea6593f19871e241d19bb6265cb48ffe03ea2eb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
