Lior Vernia has uploaded a new change for review. Change subject: webadmin: Sort NIC column in Network/Hosts subtab ......................................................................
webadmin: Sort NIC column in Network/Hosts subtab Since the column comprises not only text but possibly a label icon, it was not enough to use the default text sorting. Change-Id: Ie52ec4faafbb06a6cd62b988edc11d32db3bb765 Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/30159/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java index febf7bc..a356fe9 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java @@ -1,10 +1,12 @@ package org.ovirt.engine.ui.webadmin.section.main.view.tab.network; import java.util.Arrays; +import java.util.Comparator; import javax.inject.Inject; import org.ovirt.engine.core.common.businessentities.VDS; +import org.ovirt.engine.core.common.businessentities.comparators.LexoNumericComparator; import org.ovirt.engine.core.common.businessentities.network.NetworkView; import org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface; import org.ovirt.engine.core.common.utils.PairQueryable; @@ -224,6 +226,17 @@ clusterColumn.makeSortable(); dcColumn.makeSortable(); nicStatusColumn.makeSortable(new SimpleStatusColumnComparator<PairQueryable<VdsNetworkInterface, VDS>>(nicStatusColumn)); + nicColumn.makeSortable(new Comparator<PairQueryable<VdsNetworkInterface, VDS>>() { + + private LexoNumericComparator lexoNumeric = new LexoNumericComparator(); + + @Override + public int compare(PairQueryable<VdsNetworkInterface, VDS> o1, PairQueryable<VdsNetworkInterface, VDS> o2) { + String name1 = (o1.getFirst() == null) ? null : o1.getFirst().getName(); + String name2 = (o2.getFirst() == null) ? null : o2.getFirst().getName(); + return lexoNumeric.compare(name1, name2); + } + }); speedColumn.makeSortable(); } } -- To view, visit http://gerrit.ovirt.org/30159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie52ec4faafbb06a6cd62b988edc11d32db3bb765 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
