Lior Vernia has uploaded a new change for review. Change subject: webadmin: Render Profile main tab and subtab columns sortable ......................................................................
webadmin: Render Profile main tab and subtab columns sortable All columns are simple text columns, so it was enough to apply the default sorting implemented in TextColumnWithTooltip. Change-Id: I05fcdbc6cb30c048039ed52a1abf7e5b4e093792 Bug-Url: https://bugzilla.redhat.com/1120054 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java 3 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/30153/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java index 40829d1..2bf5b31 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java @@ -45,6 +45,7 @@ return object.getName(); } }; + nameColumn.makeSortable(); getTable().addColumn(nameColumn, constants.nameVnicProfile(), "200px"); //$NON-NLS-1$ TextColumnWithTooltip<VnicProfileView> networkColumn = new TextColumnWithTooltip<VnicProfileView>() { @@ -53,6 +54,7 @@ return object.getNetworkName(); } }; + networkColumn.makeSortable(); getTable().addColumn(networkColumn, constants.networkVnicProfile(), "200px"); //$NON-NLS-1$ TextColumnWithTooltip<VnicProfileView> dcColumn = new TextColumnWithTooltip<VnicProfileView>() { @@ -61,6 +63,7 @@ return object.getDataCenterName(); } }; + dcColumn.makeSortable(); getTable().addColumn(dcColumn, constants.dcVnicProfile(), "200px"); //$NON-NLS-1$ TextColumnWithTooltip<VnicProfileView> compatibilityVersionColumn = @@ -70,20 +73,17 @@ return object.getCompatibilityVersion().toString(); } }; + compatibilityVersionColumn.makeSortable(); getTable().addColumn(compatibilityVersionColumn, constants.compatibilityVersionVnicProfile(), "200px"); //$NON-NLS-1$ + TextColumnWithTooltip<VnicProfileView> qosColumn = new TextColumnWithTooltip<VnicProfileView>() { @Override public String getValue(VnicProfileView object) { return object.getNetworkQosName(); } }; + qosColumn.makeSortable(); getTable().addColumn(qosColumn, constants.qosNameVnicProfile(), "200px"); //$NON-NLS-1$ - TextColumnWithTooltip<VnicProfileView> descriptionColumn = new TextColumnWithTooltip<VnicProfileView>() { - @Override - public String getValue(VnicProfileView object) { - return object.getDescription(); - } - }; BooleanColumn<VnicProfileView> portMirroringColumn = new BooleanColumn<VnicProfileView>(constants.portMirroringEnabled()) { @@ -92,8 +92,16 @@ return object.isPortMirroring(); } }; + portMirroringColumn.makeSortable(); getTable().addColumnWithHtmlHeader(portMirroringColumn, constants.portMirroringVnicProfile(), "85px"); //$NON-NLS-1$ + TextColumnWithTooltip<VnicProfileView> descriptionColumn = new TextColumnWithTooltip<VnicProfileView>() { + @Override + public String getValue(VnicProfileView object) { + return object.getDescription(); + } + }; + descriptionColumn.makeSortable(); getTable().addColumn(descriptionColumn, constants.descriptionVnicProfile(), "400px"); //$NON-NLS-1$ getTable().addActionButton(new WebAdminButtonDefinition<VnicProfileView>(constants.newVnicProfile()) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java index 18386d7..4a062e6 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java @@ -43,6 +43,7 @@ return object.getName(); } }; + nameColumn.makeSortable(); getTable().addColumn(nameColumn, constants.nameTemplate(), "300px"); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java index fa035a6..45e1c4c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java @@ -43,6 +43,7 @@ return object.getName(); } }; + nameColumn.makeSortable(); getTable().addColumn(nameColumn, constants.nameVm(), "300px"); //$NON-NLS-1$ } -- To view, visit http://gerrit.ovirt.org/30153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05fcdbc6cb30c048039ed52a1abf7e5b4e093792 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
