Oved Ourfali has posted comments on this change. Change subject: core: Collect vm numa node runtime information ......................................................................
Patch Set 9: (1 comment) Eli - please review DB-related code. http://gerrit.ovirt.org/#/c/28096/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 2074: } Line 2075: } Line 2076: Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) { Line 2078: if (vm.getRunOnVds() == null) { I'd split this method to sub-methods, or arrange it a bit different, as it is mixed up. For example, you can start with retrieving, initializing and setting of runOnVdsAllNumaNodes and runOnVdsAllNumaNodesMap and then retrieve, initialize and set vmAllNumaNodes and vmAllNumaNodesMap. Also, add some spacing here. And some comments won't hurt as well. Line 2079: return; Line 2080: } Line 2081: List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds()); Line 2082: List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId()); -- To view, visit http://gerrit.ovirt.org/28096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
