Kanagaraj M has posted comments on this change. Change subject: webadmin : sort status and cluster column under volumes ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/30192/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java: Line 16: public GlusterVolumeEntity getValue(GlusterVolumeEntity object) { Line 17: return object; Line 18: } Line 19: Line 20: public void makeSortable() { is this a overriding method? Line 21: makeSortable(new Comparator<GlusterVolumeEntity>() { Line 22: Line 23: private final CustomStatusImageComaparator imageComparator = new CustomStatusImageComaparator(); Line 24: Line 17: return object; Line 18: } Line 19: Line 20: public void makeSortable() { Line 21: makeSortable(new Comparator<GlusterVolumeEntity>() { why not "new CustomStatusImageComaparator()" Line 22: Line 23: private final CustomStatusImageComaparator imageComparator = new CustomStatusImageComaparator(); Line 24: Line 25: @Override Line 28: } Line 29: }); Line 30: } Line 31: Line 32: public class CustomStatusImageComaparator implements Comparator<VolumeStatus> { This is no more comparing images Line 33: Line 34: public CustomStatusImageComaparator() { Line 35: } Line 36: -- To view, visit http://gerrit.ovirt.org/30192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73036f5a5d8e14df2bebdaeb2b3fa95938db2e8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
