Allon Mureinik has posted comments on this change. Change subject: core: Added VM memory validation on snapshot ......................................................................
Patch Set 5: Code-Review+1 (1 comment) Looks OK to me (see minor nit inline). Omer - can you please review the virt side of it? http://gerrit.ovirt.org/#/c/30040/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 153: && validate(sdValidator.allDomainsWithinThresholds()) Line 154: && validate(sdValidator.allDomainsHaveSpaceForAllDisks(newDisksList, cloneDisksList)); Line 155: } Line 156: Line 157: private List<DiskImage> getAllDisks(List<DiskImage> newDisksList, List<DiskImage> cloneDisksList) { should be static. Line 158: List<DiskImage> disksList = new ArrayList<>(); Line 159: disksList.addAll(newDisksList); Line 160: disksList.addAll(cloneDisksList); Line 161: return disksList; -- To view, visit http://gerrit.ovirt.org/30040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
